scripts: Always run ld_config before running any update scripts #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious if there will be improvements to clearlinux/distribution#1765 with this change. |
castulo
suggested changes
Feb 28, 2020
src/scripts.c
Outdated
| @@ -94,6 +94,21 @@ static void exec_post_update_script(bool reexec, bool block) | |||
| free(params[0]); | |||
| } | |||
|
|
|||
| static void run_ld_config() | |||
There was a problem hiding this comment.
you forgot the 'void' argument here, I learnt that from you 😝
There was a problem hiding this comment.
I think you forgot this ☝️
It's possible to create a post_update script to run ld_config, but we had problems with this in the past, so it was decided to hardcode that on swupd instead of relying on scripts. Signed-off-by: Otavio Pontes <[email protected]>
|
V2: Fixed the minor problems |
castulo
suggested changes
Feb 28, 2020
src/scripts.c
Outdated
| @@ -94,6 +94,21 @@ static void exec_post_update_script(bool reexec, bool block) | |||
| free(params[0]); | |||
| } | |||
|
|
|||
| static void run_ld_config() | |||
There was a problem hiding this comment.
I think you forgot this ☝️
|
Sorry, I didn't add that to the commit |
I tried adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to create a post_update script to run ld_config, but we
had problems with this in the past, so it was decided to hardcode that
on swupd instead of relying on scripts.
Signed-off-by: Otavio Pontes [email protected]